Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the trust namespace as the namespace where the role and rolebinding are created in #27

Merged
merged 1 commit into from May 4, 2022
Merged

Use the trust namespace as the namespace where the role and rolebinding are created in #27

merged 1 commit into from May 4, 2022

Conversation

JoshVanL
Copy link
Collaborator

@JoshVanL JoshVanL commented May 3, 2022

Fixes #16

/assign @SgtCoDFish

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 3, 2022
@JoshVanL
Use the trust namespace as the namespace where the role and rolebinding
c7aa07b 
are created in

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
SgtCoDFish
SgtCoDFish approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Seems like a clear fix 👌

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2022
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JoshVanL,SgtCoDFish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SgtCoDFish
Copy link
Member

/test pull-cert-manager-trust-verify

2 similar comments
@SgtCoDFish
Copy link
Member

/test pull-cert-manager-trust-verify

@SgtCoDFish
Copy link
Member

/test pull-cert-manager-trust-verify

@jetstack-bot jetstack-bot merged commit 3b24fa1 into main May 4, 2022
@SgtCoDFish SgtCoDFish deleted the trust-namespace-role-rolebinding branch June 1, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trust namespace must be equals to deployment namespace
3 participants
@JoshVanL @jetstack-bot @SgtCoDFish