Skip to content

Commit

Permalink
Adds review comment suggestions
Browse files Browse the repository at this point in the history
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
  • Loading branch information
JoshVanL committed Jan 18, 2022
1 parent 8903f5e commit 50127c5
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions content/en/docs/usage/certificate.md
Original file line number Diff line number Diff line change
Expand Up @@ -287,24 +287,24 @@ Once an X.509 certificate has been issued, cert-manager will calculate the renew

## Additional Certificate Output Formats

This feature is currently in an _experimental_ alpha state, and its behavior is
subject to change in further releases or removed entirely.

{{% pageinfo color="warning" %}}

⛔️ This feature is only enabled by adding it to the `--feature-gates` flag on
the cert-manager controller and webhook components:
⛔️ The additional certificate output formats feature is currently in an
_experimental_ alpha state, and is subject to breaking changes or complete
removal in future releases. This feature is only enabled by adding it to the
`--feature-gates` flag on the cert-manager controller and webhook components:

```bash
--feature-gates=AdditionalCertificateOutputFormats=true
```

{{% /pageinfo %}}

This feature enables defining extra output formats of the Certificate in the
target Secret resource. There are currently two supported additional output
formats: `CombinedPEM` and `DER`. Both output formats can be specified on the
same Certificate.
`additionalOutputFormats` is a field on the Certificate `spec` that allows
specifying additional supplimentory formats of issued certificates and their
private key. There are currently two supported additional output formats:
`CombinedPEM` and `DER`. Both output formats can be specified on the same
Certificate.

```yaml
apiVersion: cert-manager.io/v1
Expand Down Expand Up @@ -333,11 +333,12 @@ data:

#### `CombinedPEM`

The `CombinedPEM` option will create a new key entry in the resulting
The `CombinedPEM` type will create a new key entry in the resulting
Certificate's Secret `tls-combined.pem`. This entry will contain the PEM encoded
private key, followed by at least one new line character, followed by the PEM
encoded signed certificate chain-
```

```text
<private key> + "\n" + <signed certificate chain>
```

Expand All @@ -354,9 +355,8 @@ data:

#### `DER`

The `DER` option will create a new key entry in the resulting Certificate's
Secret `key.der`. This entry will contain the DER binary format of the private
key.
The `DER` type will create a new key entry in the resulting Certificate's Secret
`key.der`. This entry will contain the DER binary format of the private key.

```yaml
apiVersion: v1
Expand Down

0 comments on commit 50127c5

Please sign in to comment.