Bump required k8s version for csi-driver #1454
Conversation
this comes from using CSIDriver v1 unilaterally in v0.8.0 Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
jetstack-bot
added
dco-signoff: yes
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -5,7 +5,7 @@ description: 'Installation guide for cert-manager csi-driver' | |||
|
|
|||
| ## Installation Steps | |||
|
|
|||
| You must have a working installation of cert-manager present on your cluster and be running at least Kubernetes `v1.16`. | |||
| You must have a working installation of cert-manager present on your cluster and be running at least Kubernetes `v1.19`. | |||
There was a problem hiding this comment.
I think this section also needs updating/ removing: https://cert-manager.io/docs/usage/csi/#:~:text=A%20CSI%20driver,the%20deployment%20spec.
There was a problem hiding this comment.
Thanks for spotting that! I've updated it quite extensively to try and improve. Does it look better now?
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
jetstack-bot
added
size/M
| @@ -7,40 +7,43 @@ description: 'cert-manager usage: CSI driver' | |||
| <object data="/images/request-certificate-overview/request-certificate-csi.svg"></object> | |||
| </div> | |||
|
|
|||
| ## Enabling mTLS of Pods using the cert-manager CSI Driver | |||
| ## Enabling mTLS of Pods using cert-manager csi-driver | |||
There was a problem hiding this comment.
This page should actually contain info for both csi-driver and csi-driver-spiffe (based on the location in the website structure.)
There was a problem hiding this comment.
I'll probably hold off on making that change - the scope of this has already increased.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
This comes from using CSIDriver v1 unilaterally in v0.8.0
Note: K8s docs may differ slightly on the exact version when CSIDriver v1 was introduced.
Here points to v1.19 as the first version with v1 available.
That doesn't match here which claims GA (and presumably v1) came in v1.18. We use v1.19 here for safety and because these versions are so ancient that it really doesn't seem to matter.