Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link in istio-csr docs #1502

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Fix broken link in istio-csr docs #1502

merged 2 commits into from
Jun 11, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Jun 11, 2024 •
edited
Loading

The link https://github.com/cert-manager/istio-csr/tree/main/hack is no longer valid, instead https://github.com/cert-manager/istio-csr/tree/5d2e629f9f9aec7f476337d6ae69482cea9a7a71/make/config/istio can be used.

@inteon
fix broken link in istio-csr docs
fe3c70a 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 11, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 11, 2024 •
edited
Loading

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 8a83920
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/66685e2a9df37b00081b0094
😎 Deploy Preview https://deploy-preview-1502--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SgtCoDFish
SgtCoDFish approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

I don't think this should be merged while it still refers to main but I recognise it's obviously fixing a broken thing, so I'm adding a hold along with an approval.

content/v1.11-docs/projects/istio-csr.md Outdated
@@ -32,12 +32,12 @@ Running istio-csr requires a few steps and preconditions in order:
3. An `Issuer` or `ClusterIssuer` which will be used to issue Istio certificates
4. istio-csr installed (likely via helm)
5. Istio [installed](https://istio.io/latest/docs/setup/install/istioctl/) with
some custom config required, e.g. using the example config from the [repository](https://github.com/cert-manager/istio-csr/tree/main/hack).
some custom config required, e.g. using the example config from the [repository](https://github.com/cert-manager/istio-csr/tree/main/make/config/istio).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: It's great that we're fixing this and this is obviously an improvement.

While we're here, could we not use main? That's the reason this broke in the first place. If we linked to a specific revision in the docs it wouldn't auto update but it also wouldn't auto break. I'd rather have it not automatically break in the future

@cert-manager-prow cert-manager-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jun 11, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
@inteon
use permalink instead of referring to main
8a83920 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@cert-manager-prow cert-manager-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2024
@cert-manager-prow
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@inteon
Copy link
Member Author

inteon commented Jun 11, 2024

/unhold
/lgtm

@cert-manager-prow
Copy link
Contributor

@inteon: you cannot LGTM your own PR.

In response to this:

/unhold
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2024
@inteon inteon added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2024
@cert-manager-prow cert-manager-prow bot merged commit aaffd02 into cert-manager:master Jun 11, 2024
4 checks passed
@inteon inteon mentioned this pull request Jul 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@inteon @SgtCoDFish