Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restructured install documentation #647

Merged
merged 3 commits into from
Jul 23, 2021
Merged

restructured install documentation #647

merged 3 commits into from
Jul 23, 2021

Conversation

inteon
Copy link
Member

@inteon inteon commented Jul 19, 2021

Instead of Kubernetes vs OpenShift, the installation categories should be based on the installation tools.

@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jul 19, 2021
@netlify
Copy link

netlify bot commented Jul 19, 2021 •
edited
Loading

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 320ecf1

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/60f9cedb4db07d00086377a3

😎 Browse the preview: https://deploy-preview-647--cert-manager-website.netlify.app

@jetstack-bot jetstack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 19, 2021
@jetstack-bot
Copy link
Contributor

Hi @inteon. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 19, 2021
@jakexks
Copy link
Member

jakexks commented Jul 19, 2021

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 19, 2021
@inteon inteon changed the title restructured install documentatiion restructured install documentation Jul 20, 2021
@inteon
restructured install documentatiion
3186145 
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
SgtCoDFish
SgtCoDFish reviewed Jul 21, 2021
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this definitely looks like an improvement!

I know I've made a lot of comments here, but I think mostly it's stuff that was copy pasted from old docs. I like the direction this is going!

content/en/docs/installation/_index.md Outdated Show resolved Hide resolved
content/en/docs/installation/helm.md Outdated Show resolved Hide resolved
content/en/docs/installation/helm.md Outdated Show resolved Hide resolved
content/en/docs/installation/helm.md Outdated Show resolved Hide resolved
content/en/docs/installation/helm.md Outdated Show resolved Hide resolved
content/en/docs/installation/scenarios.md Outdated Show resolved Hide resolved
content/en/docs/installation/verify.md Outdated Show resolved Hide resolved
content/en/docs/installation/verify.md Outdated Show resolved Hide resolved
content/en/docs/installation/verify.md Outdated Show resolved Hide resolved
content/en/docs/installation/verify.md Outdated Show resolved Hide resolved
@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Jul 21, 2021
@inteon
Apply suggestions from code review
8ccda1e 
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Jul 21, 2021
SgtCoDFish
SgtCoDFish requested changes Jul 22, 2021
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good improvements! just a few more little bits; I'm sorry to be so thorough! 😅

content/en/docs/installation/compatibility.md Outdated Show resolved Hide resolved
content/en/docs/installation/kubectl.md Show resolved Hide resolved
content/en/docs/installation/kubectl.md Outdated Show resolved Hide resolved
content/en/docs/installation/kubectl.md Outdated Show resolved Hide resolved
content/en/docs/installation/operator-lifecycle-manager.md Outdated Show resolved Hide resolved
content/en/docs/installation/operator-lifecycle-manager.md Show resolved Hide resolved
content/en/docs/installation/verify.md Outdated Show resolved Hide resolved
@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Jul 22, 2021
@inteon @SgtCoDFish
Apply suggestions from code review
320ecf1 
Co-authored-by: Ashley Davis <SgtCoDFish@users.noreply.github.com>
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Jul 22, 2021
SgtCoDFish
SgtCoDFish approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2021
@jetstack-bot jetstack-bot merged commit 3b2195c into cert-manager:master Jul 23, 2021
@inteon inteon deleted the install_usecase_docs branch July 23, 2021 11:23
@wallrj wallrj mentioned this pull request Jul 29, 2021
Merged
@jetstack-bot jetstack-bot mentioned this pull request Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@inteon @jetstack-bot @jakexks @SgtCoDFish