Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove (or implement) unused JOB_EXPIRATION_MINUTES field from config examples #318

Closed
2 of 4 tasks
msm-code opened this issue Jan 9, 2023 · 0 comments · Fixed by #324
Closed
2 of 4 tasks

Remove (or implement) unused JOB_EXPIRATION_MINUTES field from config examples #318

msm-code opened this issue Jan 9, 2023 · 0 comments · Fixed by #324
Labels
good first issue Good for newcomers low priority Priority: low refactor Refactoring up for grabs This issue is a good candidate for PR
Milestone
v1.4.0

Comments

@msm-code
Copy link
Contributor

msm-code commented Jan 9, 2023

Feature Category

  • Correctness
  • User Interface / User Experience
  • Performance
  • Other (please explain)

Describe the problem

JOB_EXPIRATION_MINUTES field exists in config examples.

Describe the solution you'd like

This field is not used anywhere as far as I can see. We can remove it from examples.

Describe alternatives you've considered

We can also implement this feature. As far as I remember this was proposed as a solution to high redis ram usage after some time, but I don't like it too much (why would we remove good data from the db).
@msm-code msm-code added up for grabs This issue is a good candidate for PR good first issue Good for newcomers low priority Priority: low refactor Refactoring labels Jan 9, 2023
@msm-code msm-code added this to the v1.4.0 milestone Jan 9, 2023
This was referenced Jan 9, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers low priority Priority: low refactor Refactoring up for grabs This issue is a good candidate for PR
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

Migrate Mquery to typed config library CERT-Polska/mquery
1 participant
@msm-code