-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
predcorrect usability enhancements #42
Conversation
To maintain backward compatibility, users can still supply predcorrect() before a subsequent call to binless(), but they now receive a warning. However if predcorrect() is used before binning(), they will still receive warning from predcorrect(), but will also receive additional error if they then attempt to use binning().
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #42 +/- ##
==========================================
+ Coverage 80.20% 83.55% +3.34%
==========================================
Files 4 4
Lines 1051 1064 +13
==========================================
+ Hits 843 889 +46
+ Misses 208 175 -33
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
loess.ypc
argument insidebinless()
, and automatically perform LOESS prediction correction whenpredcorrect()
is used withbinless()
.binning()
either before or after usage ofpredcorrect()
binning()
is called afterpredcorrect()
,ypc
will be calculated inside thebinning()
functionpredcorrect()
andbinning()
/binless()
.This PR resolves fix #43