Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added varcorr argument to predcorrect method #60

Conversation

certara-mtomashevskiy
Copy link

@certara-mtomashevskiy certara-mtomashevskiy commented Mar 20, 2024

fixes in formatting, docs and examples
test for varcorr added

this PR resolves issue #58

fixes in formatting, docs and examples
test for varcorr added
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.30303% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 82.99%. Comparing base (cff5ec6) to head (107dea3).

❗ Current head 107dea3 differs from pull request most recent head ed2a394. Consider uploading reports for the commit ed2a394 to get more accurate results

Files Patch % Lines
R/vpcstats.R 87.50% 6 Missing ⚠️
R/vpcstats_fun.R 60.00% 4 Missing ⚠️
R/binless.R 62.50% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   83.04%   82.99%   -0.06%     
==========================================
  Files           4        4              
  Lines        1103     1129      +26     
==========================================
+ Hits          916      937      +21     
- Misses        187      192       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@certara-jcraig certara-jcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, thanks Mike.

@certara-jcraig certara-jcraig merged commit 36d329f into certara:master Mar 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants