Skip to content

Commit

Permalink
remove development dockerfile (#9676)
Browse files Browse the repository at this point in the history
  • Loading branch information
bmw committed Apr 17, 2023
1 parent 4740e20 commit 20ccf8c
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 83 deletions.
2 changes: 0 additions & 2 deletions .azure-pipelines/templates/jobs/extended-tests-jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ jobs:
IMAGE_NAME: ubuntu-22.04
PYTHON_VERSION: 3.8
TOXENV: integration-dns-rfc2136
docker-dev:
TOXENV: docker_dev
le-modification:
IMAGE_NAME: ubuntu-22.04
TOXENV: modification
Expand Down
22 changes: 0 additions & 22 deletions Dockerfile-dev

This file was deleted.

31 changes: 0 additions & 31 deletions certbot/docs/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -621,34 +621,3 @@ https://python-poetry.org/docs/dependency-specification/.

If you want to learn more about the design used here, see
``tools/pinning/DESIGN.md`` in the Certbot repo.

.. _docker-dev:

Running the client with Docker
==============================

You can use Docker Compose to quickly set up an environment for running and
testing Certbot. To install Docker Compose, follow the instructions at
https://docs.docker.com/compose/install/.

.. note:: Linux users can simply run ``pip install docker-compose`` to get
Docker Compose after installing Docker Engine and activating your shell as
described in the :ref:`Getting Started <getting_started>` section.

Now you can develop on your host machine, but run Certbot and test your changes
in Docker. When using ``docker-compose`` make sure you are inside your clone of
the Certbot repository. As an example, you can run the following command to
check for linting errors::

docker-compose run --rm --service-ports development bash -c 'tox -e lint'

You can also leave a terminal open running a shell in the Docker container and
modify Certbot code in another window. The Certbot repo on your host machine is
mounted inside of the container so any changes you make immediately take
effect. To do this, run::

docker-compose run --rm --service-ports development bash

Now running the check for linting errors described above is as easy as::

tox -e lint
19 changes: 0 additions & 19 deletions docker-compose.yml

This file was deleted.

9 changes: 0 additions & 9 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -192,15 +192,6 @@ whitelist_externals =
passenv =
DOCKER_*

[testenv:docker_dev]
description = Tests the Dockerfile-dev file to ensure development with it works as expected
deps =
commands =
docker-compose run --rm --service-ports development bash -c 'tox -e lint'
whitelist_externals =
docker-compose
passenv = DOCKER_*

[testenv:integration]
deps =
-e acme
Expand Down

0 comments on commit 20ccf8c

Please sign in to comment.