Permalink
1 comment
on commit
sign in to comment.
Browse files
Make argparse dependency unconditional. (#2249)
The primary motivation is to avoid a branch, giving bugs one fewer place to hide. But, as a bonus, more people get a more bugfixed version of argparse. (To use the example from the argparse docs, people stuck on Python 3.2.3 can get bugfixes that made it into the stdlib only in 3.2.4.)
- Loading branch information...
pva commented onApr 4, 2017
8f10103This commit and analogous in acmes breaks certbot. I receive error:
Traceback (most recent call last):
File "/usr/lib/python-exec/python2.7/certbot", line 6, in
from pkg_resources import load_entry_point
File "/usr/lib64/python2.7/site-packages/pkg_resources/init.py", line 3015, in
@_call_aside
File "/usr/lib64/python2.7/site-packages/pkg_resources/init.py", line 2999, in _call_aside
f(*args, **kwargs)
File "/usr/lib64/python2.7/site-packages/pkg_resources/init.py", line 3028, in _initialize_master_working_set
working_set = WorkingSet._build_master()
File "/usr/lib64/python2.7/site-packages/pkg_resources/init.py", line 655, in _build_master
ws.require(requires)
File "/usr/lib64/python2.7/site-packages/pkg_resources/init.py", line 963, in require
needed = self.resolve(parse_requirements(requirements))
File "/usr/lib64/python2.7/site-packages/pkg_resources/init.py", line 849, in resolve
raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'argparse' distribution was not found and is required by certbot
We should not depend on things that exist in standard library. Please, set correct sys.version_info around this dependency.
Similar issues in other projects: Gallopsled/pwntools#598
https://bugs.launchpad.net/keystone/+bug/1441083