Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make argparse dependency unconditional. (#2249)
The primary motivation is to avoid a branch, giving bugs one fewer place to hide. But, as a bonus, more people get a more bugfixed version of argparse. (To use the example from the argparse docs, people stuck on Python 3.2.3 can get bugfixes that made it into the stdlib only in 3.2.4.)
- Loading branch information
Showing
2 changed files
with
2 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f10103
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit and analogous in acmes breaks certbot. I receive error:
Traceback (most recent call last):
File "/usr/lib/python-exec/python2.7/certbot", line 6, in
from pkg_resources import load_entry_point
File "/usr/lib64/python2.7/site-packages/pkg_resources/init.py", line 3015, in
@_call_aside
File "/usr/lib64/python2.7/site-packages/pkg_resources/init.py", line 2999, in _call_aside
f(*args, **kwargs)
File "/usr/lib64/python2.7/site-packages/pkg_resources/init.py", line 3028, in _initialize_master_working_set
working_set = WorkingSet._build_master()
File "/usr/lib64/python2.7/site-packages/pkg_resources/init.py", line 655, in _build_master
ws.require(requires)
File "/usr/lib64/python2.7/site-packages/pkg_resources/init.py", line 963, in require
needed = self.resolve(parse_requirements(requirements))
File "/usr/lib64/python2.7/site-packages/pkg_resources/init.py", line 849, in resolve
raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'argparse' distribution was not found and is required by certbot
We should not depend on things that exist in standard library. Please, set correct sys.version_info around this dependency.
Similar issues in other projects: Gallopsled/pwntools#598
https://bugs.launchpad.net/keystone/+bug/1441083