Skip to content

Commit

Permalink
Merge pull request #6271 from certbot/prune_neworder
Browse files Browse the repository at this point in the history
Do not send status or resource fields in newOrder payloads for ACMEv2
  • Loading branch information
bmw committed Oct 18, 2018
2 parents 3de3188 + 6500b90 commit b9dd40b
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
3 changes: 1 addition & 2 deletions acme/acme/messages.py
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ class Order(ResourceBody):
"""
identifiers = jose.Field('identifiers', omitempty=True)
status = jose.Field('status', decoder=Status.from_json,
omitempty=True, default=STATUS_PENDING)
omitempty=True)
authorizations = jose.Field('authorizations', omitempty=True)
certificate = jose.Field('certificate', omitempty=True)
finalize = jose.Field('finalize', omitempty=True)
Expand Down Expand Up @@ -553,4 +553,3 @@ class OrderResource(ResourceWithURI):
class NewOrder(Order):
"""New order."""
resource_type = 'new-order'
resource = fields.Resource(resource_type)
13 changes: 13 additions & 0 deletions acme/acme/messages_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,19 @@ def test_to_partial_json(self):
'authorizations': None,
})

class NewOrderTest(unittest.TestCase):
"""Tests for acme.messages.NewOrder."""

def setUp(self):
from acme.messages import NewOrder
self.reg = NewOrder(
identifiers=mock.sentinel.identifiers)

def test_to_partial_json(self):
self.assertEqual(self.reg.to_json(), {
'identifiers': mock.sentinel.identifiers,
})


if __name__ == '__main__':
unittest.main() # pragma: no cover

0 comments on commit b9dd40b

Please sign in to comment.