Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support git as a reverter layer? #5553

Closed
pde opened this issue Feb 7, 2018 · 7 comments
Closed

Support git as a reverter layer? #5553

pde opened this issue Feb 7, 2018 · 7 comments

Comments

@pde
Copy link
Member

pde commented Feb 7, 2018

The reverter and rollback commands are pretty unpleasant from a UX perspective right now. We could consider the option of working with server configs in git repos (either preexisting or make one for the user), which would allow a few things to be done better:

  • Provide a rich command line for winding forward and back that people might already know
  • Be able to record which changes were made by Certbot (indeed, which exact run of Certbot)
  • Be able to record and distinguish which changes were made by the user in between Certbot runs
@pde pde added this to the Wishlist milestone Feb 7, 2018
@pde
Copy link
Member Author

pde commented Feb 7, 2018

I don't think we'd want to depend on git, but we could offer it to people who have git installed.

@pde
Copy link
Member Author

pde commented Feb 8, 2018

Or use https://github.com/dulwich/dulwich, which is a pure Python implementation of git.

@stale
Copy link

stale bot commented Jun 8, 2019

We've made a lot of changes to Certbot since this issue was opened. If you still have this issue with an up-to-date version of Certbot, can you please add a comment letting us know? This helps us to better see what issues are still affecting our users. If there is no further activity, this issue will be automatically closed.

@stale stale bot added the needs-update label Jun 8, 2019
@stale
Copy link

stale bot commented Jun 20, 2019

This issue has been closed due to lack of activity, but if you think it should be reopened, please open a new issue with a link to this one and we'll take a look.

@stale stale bot closed this as completed Jun 20, 2019
@pde
Copy link
Member Author

pde commented Jul 16, 2019

This is probably still a good intern project :)

@pde
Copy link
Member Author

pde commented Jul 16, 2019

@bmw suggest re-opening for the rainy-day wishlist :)

@bmw
Copy link
Member

bmw commented Jul 17, 2019

I'd personally prefer to leave this closed.

While this is definitely an interesting idea, I think realistically it's not something we'd ever get to. There's just too much Certbot work we could do, too few developers, and in the grand scheme of things, this seems like a pretty low priority issue to me. I don't think many people use our reverter functionality outside of automated rollbacks when we fail to make changes which wouldn't benefit from using git.

While this is just one issue, I think us closing issues like this in general helps to cleanup our issue queue helps us to more easily see the issues we actually hope to prioritize.

@bmw bmw added the wontfix label Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants