-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support git as a reverter layer? #5553
Comments
I don't think we'd want to depend on |
Or use https://github.com/dulwich/dulwich, which is a pure Python implementation of git. |
We've made a lot of changes to Certbot since this issue was opened. If you still have this issue with an up-to-date version of Certbot, can you please add a comment letting us know? This helps us to better see what issues are still affecting our users. If there is no further activity, this issue will be automatically closed. |
This issue has been closed due to lack of activity, but if you think it should be reopened, please open a new issue with a link to this one and we'll take a look. |
This is probably still a good intern project :) |
@bmw suggest re-opening for the rainy-day wishlist :) |
I'd personally prefer to leave this closed. While this is definitely an interesting idea, I think realistically it's not something we'd ever get to. There's just too much Certbot work we could do, too few developers, and in the grand scheme of things, this seems like a pretty low priority issue to me. I don't think many people use our reverter functionality outside of automated rollbacks when we fail to make changes which wouldn't benefit from using git. While this is just one issue, I think us closing issues like this in general helps to cleanup our issue queue helps us to more easily see the issues we actually hope to prioritize. |
The reverter and rollback commands are pretty unpleasant from a UX perspective right now. We could consider the option of working with server configs in git repos (either preexisting or make one for the user), which would allow a few things to be done better:
The text was updated successfully, but these errors were encountered: