Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix certbot-ci on macOS #6959

Closed
bmw opened this issue Apr 12, 2019 · 7 comments
Closed

Fix certbot-ci on macOS #6959

bmw opened this issue Apr 12, 2019 · 7 comments

Comments

@bmw
Copy link
Member

bmw commented Apr 12, 2019

When I run certbot-ci on macOS, I get the following test failures:

  • certbot-ci/certbot_integration_tests/certbot_tests/test_main.py:64 test_renew_files_permissions
  • certbot-ci/certbot_integration_tests/certbot_tests/test_main.py:88 test_renew_with_hook_scripts
  • certbot-ci/certbot_integration_tests/certbot_tests/test_main.py:26 test_manual_http_auth

All failures are due to failing to perform the HTTP challenge. An error from Pebble looks like:

Domain: le.gw3.wtf
Type:   unauthorized
Detail: Non-200 status code from HTTP: http://le.gw3.wtf:5002/.well-known/acme-challenge/MURJ9f0w83vSKPg1UaFQ-ZP5JkLNUKo5JryiSCejh8s returned 502

When I run the same code on my Ubuntu VPS, tests pass, but it would be nice if I was able to run these tests locally as well.

As the one with the Macbook, this might be on me to debug, but if anyone has any ideas I'd appreciate it. My guess is something is different with the Docker network setup on macOS vs. Linux.

cc @adferrand

@adferrand
Copy link
Collaborator

Yes, there are several blocking differences, like with Windows: https://docs.docker.com/docker-for-mac/networking/

In fact, I think that at some point, I will remove the Docker layer, at least with Traefik and Pebble, because it will simplify the runtime requirements, and these components are easily runnable directly on each platform, and that remove all problems about Docker networking. Boulder is another story.

However, I plan to do that once certbot-ci will be full running on Linux.

@stale
Copy link

stale bot commented Mar 20, 2021

We've made a lot of changes to Certbot since this issue was opened. If you still have this issue with an up-to-date version of Certbot, can you please add a comment letting us know? This helps us to better see what issues are still affecting our users. If there is no activity in the next 30 days, this issue will be automatically closed.

@stale stale bot added the needs-update label Mar 20, 2021
@adferrand
Copy link
Collaborator

Still relevant I would guess.

@stale stale bot removed the needs-update label Mar 20, 2021
@alexzorin
Copy link
Collaborator

@bmw do you have any thoughts on enhancing Pebble's CI to generate macOS releases, so that I could tox -e integration locally without hackery involving renaming binaries? It seems to otherwise pass just fine.

I get that it's like, mega low priority, but I was thinking of doing it during some relaxing downtime and wanted to see whether you knew of any reason it's a bad idea 🙏 .

@bmw
Copy link
Member Author

bmw commented Feb 17, 2022

I do not know of any reason it's a bad idea. I'd certainly appreciate it if I could trivially run Pebble locally.

@github-actions
Copy link

We've made a lot of changes to Certbot since this issue was opened. If you still have this issue with an up-to-date version of Certbot, can you please add a comment letting us know? This helps us to better see what issues are still affecting our users. If there is no activity in the next 30 days, this issue will be automatically closed.

@github-actions
Copy link

This issue has been closed due to lack of activity, but if you think it should be reopened, please open a new issue with a link to this one and we'll take a look.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants