Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Changing the ACME Server" docs out-of-date #7686

Closed
mnordhoff opened this issue Jan 16, 2020 · 5 comments
Closed

"Changing the ACME Server" docs out-of-date #7686

mnordhoff opened this issue Jan 16, 2020 · 5 comments

Comments

@mnordhoff
Copy link
Contributor

The documentation section Changing the ACME Server needs to be updated -- in particular, it still says Certbot uses Let's Encrypt's ACMEv1 API by default.

This was discovered by mojoa on the Let's Encrypt forum.

@bmw bmw added this to the 1.2.0 milestone Jan 16, 2020
@bmw
Copy link
Member

bmw commented Jan 16, 2020

Thanks for pointing this out.

If anyone is interested to submit a PR for this, we'd happily review it.

@bmw bmw added the easy-fix label Jan 27, 2020
@bmw bmw modified the milestones: 1.2.0, 1.3.0 Feb 10, 2020
@maximillianh maximillianh modified the milestones: 1.3.0, 1.4.0 Feb 24, 2020
@nomadme
Copy link

nomadme commented Mar 3, 2020

I'd like to volunteer for fixing some in the docs.

Should I fork the https://github.com/certbot/website to be able to contribute to the docs?

@bmw
Copy link
Member

bmw commented Mar 3, 2020

Thanks @nomadme!

I think @schoen was planning to work on this particular issue, but if you have other improvements in mind you'd like to make, forking the git repository and submitting a pull request is the best way to do that.

The repository for our website is https://github.com/certbot/website, however, all of the docs found at https://certbot.eff.org/docs/ including the documentation described in the issue here are in this repository (https://github.com/certbot/certbot) under the certbot/docs directory. Fork whichever repo(s) you'd like to work on!

@nomadme
Copy link

nomadme commented Mar 3, 2020

Perfect! I will scan over the issues, and see what I can do. I leave this to @schoen.

@ohemorange ohemorange self-assigned this Apr 21, 2020
@bmw
Copy link
Member

bmw commented Apr 21, 2020

This was fixed in #7924.

@bmw bmw closed this as completed Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants