Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on six #8494

Closed
bmw opened this issue Dec 2, 2020 · 0 comments · Fixed by #8650
Closed

Remove dependency on six #8494

bmw opened this issue Dec 2, 2020 · 0 comments · Fixed by #8650
Labels
area: code health has pr priority: high Issues that should be included in the current milestone if at all possible.
Milestone
1.13.0

Comments

@bmw
Copy link
Member

bmw commented Dec 2, 2020 •
edited

This should be blocked on #8389.
@bmw bmw added area: code health priority: unplanned Work that we believe should be done, but does not have a higher priority. labels Dec 2, 2020
@bmw bmw mentioned this issue Dec 2, 2020
Closed
@bmw bmw added priority: significant Issues with higher than average priority that do not need to be in the current milestone. and removed priority: unplanned Work that we believe should be done, but does not have a higher priority. labels Feb 1, 2021
@bmw bmw added this to the 1.12.0 milestone Feb 1, 2021
@bmw bmw self-assigned this Feb 1, 2021
@bmw bmw mentioned this issue Feb 2, 2021
Merged
@bmw bmw modified the milestones: 1.12.0, 1.13.0 Feb 2, 2021
@bmw bmw added priority: high Issues that should be included in the current milestone if at all possible. and removed priority: significant Issues with higher than average priority that do not need to be in the current milestone. labels Feb 4, 2021
@bmw bmw mentioned this issue Feb 8, 2021
Merged
@bmw bmw added the has pr label Feb 8, 2021
@bmw bmw removed their assignment Feb 8, 2021
@bmw bmw closed this as completed in #8650 Feb 9, 2021
bmw added a commit that referenced this issue Feb 9, 2021
@bmw
Remove dependency on six (#8650)
3d0dad8 
Fixes #8494.

I left the `six` dependency pinned in `tests/letstest/requirements.txt` and `tools/oldest_constraints.txt` because `six` is still a transitive dependency with our current pinnings.

The extra moving around of imports is due to me using `isort` to help me keep dependencies in sorted order after replacing imports of `six`.

* remove some six usage in acme

* remove six from acme

* remove six.add_metaclass usage

* fix six.moves.zip

* fix six.moves.builtins.open

* six.moves server fixes

* 's/six\.moves\.range/range/g'

* stop using six.moves.xrange

* fix urllib imports

* s/six\.binary_type/bytes/g

* s/six\.string_types/str/g

* 's/six\.text_type/str/g'

* fix six.iteritems usage

* fix itervalues usage

* switch from six.StringIO to io.StringIO

* remove six imports

* misc fixes

* stop using six.reload_module

* no six.PY2

* rip out six

* keep six pinned in oldest constraints

* fix log_test.py

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: code health has pr priority: high Issues that should be included in the current milestone if at all possible.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

Remove dependency on six certbot/certbot
1 participant
@bmw