nginx: on encountering lua directives, produce a better warning #9475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need to take a closer look, but given how sticky this problem has been in the past I like the general approach. I'm not overly familiar with lua, but looking at the documentation seems to suggest there are a few other options that might involve lua code; probably theoretically |
ohemorange
reviewed
Nov 23, 2022
certbot-nginx/tests/testdata/etc_nginx/unsupported_directives.conf
Outdated
Show resolved
Hide resolved
ohemorange
approved these changes
Nov 30, 2022
|
Haven't merged it because I wasn't sure if you wanted to add a changelog entry. |
|
Thank you! |
alexzorin
added a commit
to alexzorin/certbot
that referenced
this pull request
Feb 24, 2023
…ng (certbot#9475)" This reverts commit c178fa8.
wgreenberg
added a commit
that referenced
this pull request
Feb 27, 2023
nginx: fix performance regression caused by #9475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9066.
The code is a little bit layer violating but it seems a bit tricky to do this from
configurator.py, given that we are swallowing the parsing errors.The output becomes is as below. It's unfortunate that the warning is printed twice, once on presenting the challenge response, and one on cleaning it up. But: this already happens on
master, the situation is fairly rare and still achieves a big improvement with telling the user what's wrong.The difference compared to
masteris: