Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client to work with cert_chain_uri, "is (not) None" fixes #397

Merged
merged 1 commit into from
May 10, 2015

Conversation

kuba
Copy link
Contributor

@kuba kuba commented May 9, 2015

Demo was recently dirty-fixed to include a chain. This uncovered a couple of bugs.

We should write unittests for this module ASAP! Any kind volunteers? :)

Also, please use if foo is None or if foo is not None and not just if foo. Provided that foo can never be None, if foo should only be used if foo is a string or a container (sequence, dict, collection, etc.) and one wants to check if it's non-empty.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.32% when pulling a3c8753 on kuba:client-fetch_chain-bugs into ae31b81 on letsencrypt:master.

@kuba kuba mentioned this pull request May 9, 2015
@jdkasten
Copy link
Contributor

Thanks!

jdkasten added a commit that referenced this pull request May 10, 2015
Fix client to work with cert_chain_uri, "is (not) None" fixes
@jdkasten jdkasten merged commit 2bfd4d7 into certbot:master May 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants