Fix letsencrypt-auto name and long forms of -n

[bmw]

I added NONINTERACTIVE in addition to ASSUME_YES because while we want certbot-auto renew to be non-interactive, I don't want every cron job in the world to rebootstrap without the user's permission. This fixes the long forms --noninteractive and --non-interactive and also makes letsencrypt-auto auto-upgrade as its behavior has always been install things without prompting the user.

I tested this by merging this and #5329 together and making the following changes:

diff --git a/letsencrypt-auto-source/tests/centos6_tests.sh b/letsencrypt-auto-source/tests/centos6_tests.sh
index e3ebbae..9ca8043 100644
--- a/letsencrypt-auto-source/tests/centos6_tests.sh
+++ b/letsencrypt-auto-source/tests/centos6_tests.sh
@@ -25,7 +25,7 @@ if [ $RESULT -ne 0 ]; then
 fi
 
 # bootstrap, but don't install python 3.
-certbot/letsencrypt-auto-source/letsencrypt-auto --no-self-upgrade -n > /dev/null 2> /dev/null
+certbot/letsencrypt-auto-source/letsencrypt-auto --no-self-upgrade > /dev/null 2> /dev/null
 
 # ensure python 3 isn't installed
 python3 --version 2> /dev/null
@@ -47,8 +47,18 @@ if [ $RESULT -eq 0 ]; then
   exit 1
 fi
 
+cp certbot/letsencrypt-auto-source/letsencrypt-auto ./certbot-auto
+./certbot-auto --no-self-upgrade >/dev/null 2>&1
+# ensure python 3 isn't installed
+python3 --version 2> /dev/null
+RESULT=$?
+if [ $RESULT -eq 0 ]; then
+  error "Python3 is already installed."
+  exit 1
+fi
+
 # bootstrap, this time installing python3
-certbot/letsencrypt-auto-source/letsencrypt-auto --no-self-upgrade -n > /dev/null 2> /dev/null
+./certbot-auto --no-self-upgrade --non-interactive > /dev/null 2> /dev/null
 
 # ensure python 3 is installed
 python3 --version > /dev/null

[ohemorange]

For the test, it seems we'd only want to change:

# bootstrap, this time installing python3
-certbot/letsencrypt-auto-source/letsencrypt-auto --no-self-upgrade -n > /dev/null 2> /dev/null
+certbot/letsencrypt-auto-source/letsencrypt-auto --no-self-upgrade --non-interactive > /dev/null 2> /dev/null

Because that's the minimal change to check that this fix worked.

To be clear, what are the cases where we do want to rebootstrap? Could you put down your expectations for the powerset of the following variables?

• renew/ not renew
• terminal attached/ no terminal attached
• non-interactive set/ not set

[ohemorange]

If we're not actually using this flag for anything, we shouldn't set it.

[ohemorange]

And if we are leaving this, we should probably also check the short-form.

[bmw]

NONINTERACTIVE is the flag we use to determine it's OK to rebootstrap without user intervention. See https://github.com/certbot/certbot/blob/v0.20.0/certbot-auto#L833.

And we do check the short form but due to the fun of POSIX compatible shell scripting, we have to check for the short form differently. See https://github.com/certbot/certbot/blob/v0.20.0/certbot-auto#L83.

[bmw]

For the test, it seems we'd only want to change ...

Sure that's fine. I just quickly added different tests to verify it worked.

To be clear, what are the cases where we do want to rebootstrap? Could you put down your expectations for the powerset of the following variables?

Renew has no affect on whether or not we rebootstrap. For the other variables, if either a terminal is attached or -n/--non-interactive/--noninteractive is set, we'll reboostrap if we need to, otherwise, we will not.

EDIT: The other variable there that's not mentioned is the name of the script (while hacky, this was necessary for improving certbot-auto while keeping backwards compatibility). If the name of the script is letsencrypt-auto, it is equivalent to -n being set.

[ohemorange]

Ahh, missed that we handle shortform differently. LGTM.