New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to dns_rfc2136 plugin to specify an authorative base domain. #7029
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some little improvements on the code comments, otherwise LGTM!
@adferrand I changed the comments according to your remarks. Would be great if you could have a look at it. |
Yes of course, all good for me now! |
Oups forgot one thing, really sorry about that: could you make one other PR to add I will merge your new PR right after. |
Yes sure, no problem. |
Added an option to dns_rfc2136 plugin to explicitly specify the base domain for which the DNS server is authorative. This solves problems with split horizon DNS configurations which do not correctly report authorative SOA records when queried without a TSIG key. Could be useful for other use cases.