Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #7165 in _create_challenge_dirs() #7356

Closed
wants to merge 2 commits into from
Closed

Fix issue #7165 in _create_challenge_dirs() #7356

wants to merge 2 commits into from

Conversation

martin-c
Copy link
Contributor

Some operating systems won't reliably raise EEXIST or EISDIR if a directory exists when filesystem.mkdir() is called, instead raising Read-only file system errors or similar even when path is in fact writable. To work around this we include a check to see if directory already exists. See Issue #7165 for more information.

Pull Request Checklist

  • Edit the master section of CHANGELOG.md to include a description of
    the change being made.
  • Add mypy type
    annotations

    for any functions that were added or modified.
  • Include your name in AUTHORS.md if you like.

Some operating systems won't reliably raise EEXIST or EISDIR if a directory exists when filesystem.mkdir() is called, instead raising `Read-only file system` errors or similar even when path is in fact writable. To work around this we include a check to see if directory already exists. See Issue #7165 for more information.
Copy link
Collaborator

@adferrand adferrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @martin-c, the PR almost LGTM! Could you merge/rebase master, fix the lint error and add a changelog entry? Then I will merge.

@martin-c
Copy link
Contributor Author

webroot.py has been moved to certbot/_internal/plugins/webroot.py and I'm not sure how to apply my changes to the original file there. I will make a new pull request.

@martin-c martin-c closed this Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants