Improve standalone errors #8919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexzorin
force-pushed
the
standalone-error-ux
branch
from
5903676
to
b78f71e
Compare
ohemorange
requested changes
Jun 21, 2021
| neat_addr = f"{addr}:{port}" if addr else f"port {port}" | ||
| return ("The Certificate Authority failed to download the challenge files from " | ||
| f"the temporary standalone webserver started by Certbot on {neat_addr}. " | ||
| "Ensure the listed domains point to this server and that this server can accept " |
There was a problem hiding this comment.
Suggested change
| "Ensure the listed domains point to this server and that this server can accept " | |
| "Ensure the listed domains point to this server and that this machine can accept " |
There was a problem hiding this comment.
I think the preceding "server" refers to the same thing. Would something like this be more correct:
Ensure that the listed domains point to this machine and that it can accept inbound connections from the internet
There was a problem hiding this comment.
Ah, yes, true. That looks great!
alexzorin
force-pushed
the
standalone-error-ux
branch
from
b78f71e
to
f137d84
Compare
ohemorange
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's two changes here:
EACCESandEADDRINUSE. It seems that this functionality was accidentally lost during a change toacme.standalonea long time ago. We go from seeing a very generic error message inmaster:I suggest merging this PR instead of squashing it.
Fixes #8887.