Recommend creating http.Transport with default settings #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now the recommended way to create a transport in golang 1.13, to ensure that default settings (such as to close idle connections) are inherited.
|
ooo, is this new in 1.13, or just recommended since 1.13? |
|
New in go 1.13, golang/go#26013 (comment) |
|
Then can we maybe just document both since 1.13 is still relatively new? |
|
I suppose that's fair, although the old way is quite bad as it initializes many fields as zero and can lead to resource exhaustion because idle connections are set to unlimited with no timeout. |
|
I agree. But if you’re using 1.12, you don’t really have a choice. In theory, we could provide our own method of like, “NewHttpTransport()” that did the right thing in < 1.12 and 1.13. |
|
Okay I documented both ways. |
|
Thank you! And I’ve learned something here today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now the recommended way to create a transport in golang 1.13, to ensure that default settings (such as to close idle connections) are inherited.