Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing copyright notices #140

Closed
ghost opened this issue Sep 8, 2017 · 3 comments
Closed

Missing copyright notices #140

ghost opened this issue Sep 8, 2017 · 3 comments
Labels
bug
Milestone
1.1.0

Comments

@ghost
Copy link

ghost commented Sep 8, 2017

No files except those in debian/ have copyright notices, see https://reuse.software/#two
@ghost ghost added the bug label Sep 8, 2017
@ghost ghost added this to the Release 1.0 milestone Sep 8, 2017
@dmth
Copy link

dmth commented Sep 11, 2017

It might make sense to update the "developers guide" https://github.com/certtools/intelmq/blob/develop/docs/Developers-Guide.md#license-and-author-files in order to allow listing of the license and the authors within the code-files:

License and authors must be only listed in an external file but not inside the code files.

@ghost
Copy link
Author

ghost commented Sep 11, 2017

The dev guide should certainly be adapted after we know how to deal with these issues. But probably after we know more about this stuff? :)

@ghost ghost self-assigned this Mar 22, 2018
@ghost
Copy link
Author

ghost commented Apr 23, 2018

licenses are declared in debian/copyright and LICENSES/ now. Dev guide has been updated in ab573db
Moving this to the next version

@ghost ghost modified the milestones: Release 1.0, Release 1.1 Apr 23, 2018
ghost pushed a commit that referenced this issue Sep 25, 2018
Merge tag '1.0.2'
6413e26 
1.0.2 Bugfix release

 ### Backend
- Emit a more specific error message for cases like #160.
- The timeout for calls to `intelmqctl` has been raised to 20s (#164).

 ### Pages

 #### Configuration
- Underscore is now allowed for new parameter names (#153).

 #### Monitor
* Fix link to monitor page (#157).

 ### Documentation
- Add a FAQ and add a section about the docker issue (#160).
- Add instructions for Debian 9, Ubuntu 18.04, and openSUSE Leap 42.3, 15.0 (#168).

 ### Packaging
- Include a positions file matching the default configuration of intelmq (#171).

 ### Known issues
* Missing CSRF protection (#111).
* Missing copyright notices (#140).
* Graph jumps around on "Add edge" bug component (#148).
* new runtime parameters with _ not possible (#153).
* wrong error message for new bots with existing ID (#152).
* Queue size for deleted queue remains displayed (#158).
@ghost ghost closed this as completed in 41cffde Nov 12, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@dmth