Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deb packages: Failed check in postinst causes configure step to fail #1748

Closed
ghost opened this issue Feb 17, 2021 · 0 comments
Closed

Deb packages: Failed check in postinst causes configure step to fail #1748

ghost opened this issue Feb 17, 2021 · 0 comments
Labels
bug Indicates an unexpected problem or unintended behavior packaging
Milestone

Comments

@ghost
Copy link

ghost commented Feb 17, 2021

The deb packages run intelmqctl check in postinst:

runuser -u intelmq -- /usr/bin/intelmqctl -q check --no-connections

This is fine and reports configuration errors to the administrator. However, a non-zero exit code can happen and this will cause the configure step to fail which has implications on the installation of the IntelMQ and other dependent packages. In upgrades to 2.3.0 this will cause that the Manager and API won't work.

We should therefore ignore the exit code of intelmqctl check in the postinst. For the intelmqctl upgrade-config call, it's OK to fail for non-zero exit codes, as that should not happen and would mean a bug in IntelMQ.

@ghost ghost added bug Indicates an unexpected problem or unintended behavior packaging labels Feb 17, 2021
@ghost ghost added this to the 2.3.0 milestone Feb 17, 2021
@ghost ghost self-assigned this Feb 19, 2021
@ghost ghost closed this as completed in e339c16 Feb 19, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior packaging
Projects
None yet
Development

No branches or pull requests

0 participants