Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot command line parameters for manual interaction #214

Closed
ghost opened this issue Jun 5, 2015 · 7 comments
Closed

Bot command line parameters for manual interaction #214

ghost opened this issue Jun 5, 2015 · 7 comments
Milestone

Comments

@ghost
Copy link

ghost commented Jun 5, 2015

I propose to add to the bot class some command line handling
with the following characteristics:

  1. Add a --debug flag which starts a bot in a debug mode, which:
    a. loads pdb (python debugger)
    b. sets breakpoint for process method for bot
    c. waits there for user input (pdb actually does that)
  2. Add a --help directive to display a help message, which is generated by reading BOTS file.
  3. Add the ability to give the bot parameters from the command line, maybe by prefixing each parameter in the BOTS file with '--', so for example a theoretical parameter "account_name" we would have "bot --account_name=foobar"

What do you think? I obviously like that idea ...

@aaronkaplan
Copy link
Member

My 2 cents: right now, I would not like to focus on this. Before that I want to see better unit tests for all bots. As mentioned, that's my 2 cents.
I like suggestion 3. However, again ... feature creep , later.. let's focus on the core issues first.

@SYNchroACK
Copy link
Contributor

The idea is interesting but as @aaronkaplan said, is not a priority.

@SYNchroACK SYNchroACK added feature request Indicates new feature requests not priority labels Jun 6, 2015
@SYNchroACK SYNchroACK added this to the Release 3 milestone Jun 6, 2015
@SYNchroACK SYNchroACK changed the title Core - Bot command line parameters for manual interaction Bot command line parameters for manual interaction Jun 6, 2015
@SYNchroACK SYNchroACK added invalid: wontfix and removed feature request Indicates new feature requests not priority labels Feb 1, 2017
@SYNchroACK
Copy link
Contributor

similar features were already implemented with intelmqctl and a lot of new information was documented.

@ghost
Copy link

ghost commented Apr 24, 2017

As far as I see, the feature request has been postponed, not rejected, right?

@ghost ghost reopened this Apr 24, 2017
@ghost ghost added component: core component: intelmqctl feature request Indicates new feature requests and removed invalid: wontfix labels Apr 24, 2017
@ghost
Copy link

ghost commented Dec 13, 2017

The first issue is resolved, we have a debugger. See #975

@ghost
Copy link

ghost commented Aug 6, 2018

The third issues is also in #698

@ghost
Copy link

ghost commented Aug 6, 2018

And the second needs/is solved by #632 #757.
Closing here, as we have separate issues for all ideas too.

@ghost ghost closed this as completed Aug 6, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants