Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp32-c3 build fails with unknown CMake command "add_prebuilt_library" #605

Closed
nliviu opened this issue Feb 23, 2023 · 5 comments
Closed

Comments

@nliviu
Copy link
Collaborator

nliviu commented Feb 23, 2023

After the latest commit as of 22/02/2023 build for esp32c3 fails

CMake Error at /mongoose-os/platforms/esp32xx/esp32xx.cmake:11 (add_prebuilt_library):
  Unknown CMake command "add_prebuilt_library".

It looks like /mongoose-os/platforms/esp32c3/CMakeLists.txt is missing

include($ENV{IDF_PATH}/tools/cmake/project.cmake)
@nliviu nliviu changed the title esp32-c3 build fails with known CMake command "add_prebuilt_library" esp32-c3 build fails with unknown CMake command "add_prebuilt_library" Feb 23, 2023
@rojer
Copy link
Collaborator

rojer commented Feb 23, 2023

@a2800276 can you check and put up a fix please?

@a2800276
Copy link
Contributor

Ah yes, didn't copy over to esp32c3, sorry.
Let me try to set up a mini project to build for both plattforms.

@a2800276
Copy link
Contributor

Ok, I've copied the CMakeFiles.txt and tested it: #606

I'm not sure how you guys typically go about testing the build. I tried building demojs app for esp32 and esp32c3 before and after, before esp32 worked and c3 failed, after both build suceeded.

@rojer rojer closed this as completed Feb 23, 2023
@nliviu
Copy link
Collaborator Author

nliviu commented Feb 23, 2023

Thank you!

@a2800276
Copy link
Contributor

No worries, I should have tested the PR before submitting. Sorry about being the elephant in the china shop in the first place :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants