Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue 605, CMakeLists.txt for esp32c3 and esp32 shared #606

Merged
merged 1 commit into from
Feb 23, 2023
Merged

fix for issue 605, CMakeLists.txt for esp32c3 and esp32 shared #606

merged 1 commit into from
Feb 23, 2023

Conversation

a2800276
Copy link
Contributor

The idea behind the previous PR was to reduce redundancy between esp32 and esp32c3 since their CMakeLists.txt were identical. Unfortunately, the 'include' stub of both should have also been identical, but weren't. And I did not test building for esp32c3.

I tested now as follows:

$ mos update latest
$ mos clone https://github.com/mongoose-os-apps/demo-js app1
$ mos build ... --platform esp32 # succeeds
$ mos build ... --platform esp32c3 #fails 
# apply this PR
$ rm -rf build
$ mos build ... --platform esp32c3 #succeeds
$ mos build ... --platform esp32 # succeeds

I'm not sure how you typically go about testing the build system...

#605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants