Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESP32-S3 to ESP32 docker build #601

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

duncandrennan
Copy link
Contributor

@duncandrennan
Copy link
Contributor Author

  • Updated this to use Mongoose OS ESP-IDF
  • Builds with DOCKER_TAG=4.4.1-r1

@rojer
Copy link
Collaborator

rojer commented Jun 11, 2022

i think we can support all ESP32 devices (or all devices supported by ESP-IDF, really) with one image, we just need to include the toolchains

@duncandrennan
Copy link
Contributor Author

That makes sense. The only thing that I'm not sure about is how the environment variable MGOS_TARGET_GDB propagates through the mos system, as well as how rom.bin/elf are used. I see debug_core_dump.go (in mos tool) configures the platformDebugParams, so the rom files can be set that way. Looking further it looks like the MGOS_TARGET_GDB could also be shifted to the platformDebugParms and then appended in the same way as dp.extraServeCoreArgs.

Then each platform could have its own define, e.g. MGOS_TARGET_GDB_ESP32 (or ESP32S3, etc.).

@duncandrennan duncandrennan changed the title Add docker build for ESP32-S3 Add ESP32-S3/C3 to ESP32 docker build Jun 12, 2022
@duncandrennan
Copy link
Contributor Author

I've updated this to build single ESP32 (ESP-IDF) docker image. I've left the existing defines/files (in particular rom.bin/elf and MGOS_TARGET_GDB) and added items for the -S3/C3. -S3 ROM is not yet available from the download link provided here, https://docs.espressif.com/projects/esp-idf/en/v4.4.1/esp32s3/api-guides/core_dump.html#rom-functions-in-backtraces.

Also updated the PR mongoose-os/mos#72

@rojer
Copy link
Collaborator

rojer commented Jun 12, 2022

please rebase

@duncandrennan duncandrennan changed the title Add ESP32-S3/C3 to ESP32 docker build Add ESP32-S3 to ESP32 docker build Jun 13, 2022
@duncandrennan
Copy link
Contributor Author

Rebased

@rojer rojer merged commit b74db6e into cesanta:master Jun 13, 2022
@rojer
Copy link
Collaborator

rojer commented Jun 13, 2022

merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants