Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Modelparams #26

Merged
merged 5 commits into from
Nov 11, 2020
Merged

Use Modelparams #26

merged 5 commits into from
Nov 11, 2020

Conversation

rafaqz
Copy link
Member

@rafaqz rafaqz commented Nov 11, 2020

This is a major breaking change. No more FieldMetadata.jl - Param from ModelParameters.jl instead.

  • Params show up in a table in the REPL
  • There is no global state - Params are added for specific models
  • model params can be saved and loaded to tables - CSV/Datafram etc
  • The interface is now just a wrapper to InteractModels - there is not Interact.jl code included, and no direct Interact.jl dep.

Various stress models like HeatStress have also been deleted - now you can just specifify the label and bounds in the Param as you need to using the generic LowerStress and UpperStress

@codecov-io
Copy link

Codecov Report

Merging #26 (c1391ae) into master (cb2026b) will decrease coverage by 1.74%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   98.44%   96.70%   -1.75%     
==========================================
  Files           4        4              
  Lines         129       91      -38     
==========================================
- Hits          127       88      -39     
- Misses          2        3       +1     
Impacted Files Coverage Δ
src/GrowthMaps.jl 100.00% <ø> (ø)
src/fit.jl 96.29% <100.00%> (-1.82%) ⬇️
src/framework.jl 97.61% <100.00%> (-2.39%) ⬇️
src/models.jl 95.23% <100.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb2026b...c1391ae. Read the comment docs.

@rafaqz rafaqz merged commit 94f0045 into master Nov 11, 2020
@rafaqz rafaqz deleted the modelparams branch November 27, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants