Add ELF exporting logic. #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be honest, I'm a bit leery of this. The Ghidra ElfExporter has had some serious bugs; NationalSecurityAgency/ghidra#19 tracks issues that it's had since the beginning. Although I hope the issues have been fixed, I'd like to know if you've run into any issues with the exporter? In particular, I would like to know if the exporter changes anything compared to the on-disk file. |
|
We haven't run into issues yet, but we also haven't been looking for them. |
|
FWIW, we tried out ELF export this weekend on 10.3 (not specifically this PR, just the Ghidra feature) and wound up with executables that didn’t work properly. We haven’t debugged in detail what went wrong yet. |
|
Closing in favour of #24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #13.