Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock out additional readthedocs libraries #123

Merged
merged 2 commits into from Dec 17, 2015

Conversation

bnaul
Copy link
Contributor

@bnaul bnaul commented Dec 17, 2015

Some libraries were already present on Drone (e.g. requests) and not readthedocs; from now on Drone should fail whenever readthedocs is missing a dependency or mock library.

Also fixes a docstring indentation warning.

@acrellin
Copy link
Member

👍

@acrellin
Copy link
Member

stefanv: 👍

acrellin added a commit that referenced this pull request Dec 17, 2015
Mock out additional readthedocs libraries
@acrellin acrellin merged commit 0f7d506 into cesium-ml:master Dec 17, 2015
@stefanv
Copy link
Contributor

stefanv commented Dec 18, 2015

I like how I have become a Jeff Dunham special.

@stefanv
Copy link
Contributor

stefanv commented Dec 18, 2015

Also, this PR is going to come and bite us in the ass, but at least we'll know it when it happens. Or perhaps we can build a small tool to generate a list of all external imports automatically?

@acrellin
Copy link
Member

stefanv: 👍

On Thursday, December 17, 2015, Stefan van der Walt <
notifications@github.com> wrote:

Also, this PR is going to come and bite us in the ass, but at least we'll
know it when it happens. Or perhaps we can build a small tool to generate a
list of all external imports automatically?


Reply to this email directly or view it on GitHub
#123 (comment).

@acrellin
Copy link
Member

😉

@bnaul
Copy link
Contributor Author

bnaul commented Dec 18, 2015

¯_(ツ)_/¯

@acrellin
Copy link
Member

@bnaul let's look into building a tool that auto-generates a 👍 from
Stefan as soon as one of us creates a PR.

On Friday, December 18, 2015, Brett Naul notifications@github.com wrote:

¯_(ツ)_/¯


Reply to this email directly or view it on GitHub
#123 (comment).

@stefanv
Copy link
Contributor

stefanv commented Dec 18, 2015

What have I done.

@bnaul bnaul deleted the bnaul-docs branch January 27, 2016 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants