-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tighten up spec when content.url is another tileset #42
Comments
None that I can think of at the moment. Perhaps it should be noted somewhere that the geometric error of a tile with tiles.json content should be the same as that of its tiles.json root? Or should it be flexible? |
Semantically, I think we see the external tiles.json root tile as the same as the parent tile so I agree both tiles should have the same geometric error. I made a note above. |
Actually, does this buy us anything in the implementation? We would also want to make the same claim about the |
A Shall we treat all root tiles as |
I'm growing a bit skeptical of allowing children to a tiles.json tile. It makes the implementation more complex/confusing, and doesn't enable any structure that wouldn't be possible without it (right?). If we want to support it, there will be some unintuitive relations between the tiles involved that are probably not warrented by any use-cases (the use-cases I thought about earlier, would be just as well supported by a no-children specification, I've realized). |
OK, let's not allow it. I updated the wording at the top of this issue. We can always relax it in a later version of the spec if there is a real need, but I agree with your point that it doesn't enable any new structures. |
Given that we are not allowing a tile to point to a tiles.json and have children, let's say that the tile and tiles.json root are semantically the same so their If you agree, I'll update the top comment of this issue. Then I'll close this and update the spec once the implementation in CesiumGS/cesium#3237 is complete in case we run into anything else. |
Sounds good! |
Great, updated above: #42 (comment) |
Lessons learned from CesiumGS/cesium#3237
A tile with
content.url
pointing to an external tileset (another tile.json):children
.root.geometricError === tile.geometricError
androot.box === tile.content.box
(or equalstile.box
iftile.content.box
isundefined
).@e-andersson any other corner cases we should add to the spec?
The text was updated successfully, but these errors were encountered: