Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node string limitations #59

Open
lilleyse opened this issue Apr 12, 2017 · 4 comments
Open

Node string limitations #59

lilleyse opened this issue Apr 12, 2017 · 4 comments
Labels

Comments

@lilleyse
Copy link
Contributor

Buffers larger than ~192MB cannot be base64 encoded due to a NodeJS limitation. nodejs/node#4266

It would be good to get around this. In most cases however using the --separate flag is the way go.

@lilleyse lilleyse added the bug label Apr 12, 2017
@patty-victor
Copy link

Any changes on this?

@lilleyse
Copy link
Contributor Author

No change right now - however both --separate and --binary are not affected by this problem. This only happens when embedding resources as data-uris.

@roy7
Copy link

roy7 commented Mar 27, 2018

You might try this in node v8.10. It fixed a problem we were having with a max string size limitation.

@likangning93
Copy link
Contributor

likangning93 commented Feb 19, 2019

Heads-up that we may also be able to reduce instances of the string limitation by binning buffers, iirc obj2gltf tries to generate a single output buffer, but there's tons of models out there where the geometry can be "binned" into multiple buffers based on something simple like material use or perhaps different vertex attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants