Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not go to Favorites after return from settings #13

Closed
OndrejMalek opened this issue May 28, 2022 · 2 comments
Closed

Can not go to Favorites after return from settings #13

OndrejMalek opened this issue May 28, 2022 · 2 comments

Comments

@OndrejMalek
Copy link
Contributor

OndrejMalek commented May 28, 2022 •
edited

tab click not working

Steps to reproduce:

  1. open app
  2. in dict click phrase section
  3. type 'ro' into search field
  4. click bottom bar 'favorites'
  5. click bottom bar 'settings'
  6. click bottom bar 'dict'
    result: U are in dict-dict, when click favorites tab nothing happens
    expected: U are in dict-favorites, tab click are working
@OndrejMalek
Copy link
Contributor Author

df

OndrejMalek added a commit that referenced this issue May 29, 2022
@OndrejMalek
Can not go to Favorites after return from settings #13 fix: check su…
d4f08da 
…bsection state (if in fav or dict) by asking navigation component instead of tab state which can be off sync in this case

 #13
  Can not go to Favorites after return from settings #13
  tab click not working

  Steps to reproduce:

      open app
      in dict click phrase section
      type 'ro' into search field
      click bottom bar 'favorites'
      click bottom bar 'settings'
      click bottom bar 'dict'
      result: U are in dict-dict, when click favorites tab nothing happens
      expected: U are in dict-favorites, tab click are working
@vchlum
Copy link
Collaborator

vchlum commented Jun 2, 2022

done

@vchlum vchlum closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OndrejMalek @vchlum