Unit testy na kontrolu stavu dat #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skvělý nápad jakube, toto je úplně super! |
pionl
reviewed
Mar 25, 2023
|
|
||
| dataStore.dictionary?.phrases.values.forEach { phrase in | ||
| if let soundFileName = phrase.source.soundFileName { | ||
| let sound = NSDataAsset(name: "data/uk-sounds/\(soundFileName)") |
There was a problem hiding this comment.
nešlo by to generování cest přesunout do společné logiky? (i u sotires)
There was a problem hiding this comment.
Teď už je to jednodušší, kdybych měl odstranit kompletně to skládání, bylo by pak potřeba zrefaktorovat celou část ohledně načítání a pouštění zvuků. Do toho se mi teď úplně pouštět nechce.
|
Nešlo by logovat na čem to spadlo?
|
Nemám tušení proč, ale fastlane nevypisuje message, které jsou u assertů. :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134
V datech je chyba viz https://cesko-digital.slack.com/archives/C03BYED3ARK/p1679765287700179 potřebujeme se pobavit o tom jak to opravit. Zda opravit appku a nebo data.