Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Reverse proxy configuration documentation #142

Merged
merged 4 commits into from
Jan 20, 2022
Merged

Conversation

zakaria2905
Copy link
Contributor

Adapting REVERSEPROXY.md for traefik ingress feature in helm-fadi:
https://github.com/cetic/helm-fadi/tree/feature/traefik-ingress

@banzo banzo self-requested a review December 9, 2021 14:31
@banzo banzo changed the title Update REVERSEPROXY.md Reverse proxy configuration documentation Dec 13, 2021
@banzo
Copy link
Member

banzo commented Dec 13, 2021

  • Add ingress to Superset
  • document the port forward command pour adminer/phpldapadmin (in userguide and usermanagement at least)

Changes needed to INSTALL.md:

  • do not activate the minikube ingress plugin
  • remove kubectl config set-context minikube

Update userguide:

  • minikube service is not working anymore
  • creating the tunnel
  • how to update hosts file (linux, mac, windows)

Changes needed to deploy.sh:

  • missing helm dep up

@banzo banzo assigned zakaria2905 and banzo and unassigned zakaria2905 Jan 4, 2022
@banzo
Copy link
Member

banzo commented Jan 10, 2022

Some of the review comments still need to be addressed:

  • do we really need to introduce the example.yaml instead of the values.yaml? if really needed, explain how to use it instead of the default values.yaml file.
  • we should come up with a url scheme that is more relevant, something like dashboard.traefik.fadi.cetic.be maybe?
  • explain why we do not set it as secure, and how it should be configured in production
  • make a link to the ingressroutes file (in helm-fadi I guess?)

I am guessing some are also taken care of in #144, please check.

@banzo banzo assigned zakaria2905 and unassigned banzo Jan 10, 2022
Copy link
Member

@banzo banzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above

doc/REVERSEPROXY.md Outdated Show resolved Hide resolved
doc/REVERSEPROXY.md Outdated Show resolved Hide resolved
doc/REVERSEPROXY.md Outdated Show resolved Hide resolved
doc/REVERSEPROXY.md Show resolved Hide resolved
doc/REVERSEPROXY.md Outdated Show resolved Hide resolved
doc/REVERSEPROXY.md Outdated Show resolved Hide resolved
@banzo banzo merged commit 65a839b into master Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants