This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Add secrets #52
Merged
Add secrets #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Lindeman <patrick@plicon.nl>
Signed-off-by: Patrick Lindeman <patrick@plicon.nl>
Signed-off-by: Patrick Lindeman <patrick@plicon.nl>
|
i noticed i didn't update the version of the chart in the initial PR, so updated it to 1.2.0 which now caused a conflict .. |
|
Conflicts resolved |
|
Hello @plicon! Thank you very much for your contribution to the project. I've been away for a few weeks. I'll look at the Pull Request carefully and make my thoughts before the merge. |
|
Hi @plicon! Good job in this Pull Request. Thanks for your contributition. Greetings. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR allows users to configure a secret for connecting to postgresql server, instead of using clear text strings.
Configurable for both server and web.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]