Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix query parameter representing protocol header with protocol name. #7

Closed
flowersinthesand opened this issue May 31, 2015 · 1 comment
Assignees
Milestone

Comments

@flowersinthesand
Copy link
Member

flowersinthesand commented May 31, 2015

How to represent protocol header depends on each transport but now all supported transports including even socket are using URI's query component. However because user may use query as well to attach some information according to the original purpose of query as a component of URI, it might conflict with ones used to represent protocol header.

To avoid confusion, every query parameter representing protocol header should be prefixed with their protocol name such as cettia or cettia-transport. For example, from the point of view of http server, a URI of one of requests belonging to http streaming transport

http://localhost:8080/cettia/?user-foo=bar&transport=stream&id=${transport.id}&sid=${socket.id}

should be rewritten to

http://localhost:8080/cettia/?foo=bar&cettia-transport-name=stream&cettia-transport-id=${transport.id}&cettia-id=${socket.id}
@flowersinthesand
Copy link
Member Author

flowersinthesand commented May 1, 2017

  • sid to cettia-id
  • heartbeat to cettia-heartbeat
  • _heartbeat tocettia-_heartbeat
  • id to cettia-transport-id
  • when to cettia-transport-when
  • transport to cettia-transport-name
  • sse to cettia-transport-sse
  • jsonp to cettia-transport-jsonp
  • callback to cettia-transport-callback

flowersinthesand added a commit to cettia/cettia-java-server that referenced this issue May 4, 2017
flowersinthesand added a commit to cettia/cettia-javascript-client that referenced this issue May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant