Dendrogram pickup - code review 2 #282
Conversation
There was a problem hiding this comment.
More comments sorry 🙃 nice work though!
Could you tidy up the formatting of the if statements please? The conditional doesn't need brackets and always put the result on a new line (unless its an inline statement).
if conditional {
result
}
Also I would prefer a single assignment for conditonal assignments. So instead of
let a = 0
if b {
a = 1
}
do
let a = if b { 1 } else { 0 }
// or
let a = if b {
1
} else {
0
}
I appreciate the candid and constructive feedback. I'm still new to Typst, and haven't written a single line of rust, so its useful to learn appropriate styles and code-smells to avoid |
|
Getting there! |
|
I'd like to implement and use polar axes for this. Maybe I'll find some time during the weekend, as I am not really happy about how the "radial" mode looks with the Cartesian axes right now. |
Definitely agreed. Cartesian axes are only there because of a lack of alternative at the moment. Polar axes would be great though! |
Made most of the changes requested in the code review. There's still some more work to be done most likely, but it got a bit tricky seeing what each message was referring to given the amount of changes made