Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupt jars files following SocketTimeoutException #125

Closed
tombentley opened this issue Sep 2, 2015 · 2 comments
Closed

Corrupt jars files following SocketTimeoutException #125

tombentley opened this issue Sep 2, 2015 · 2 comments
Assignees
Milestone

Comments

@tombentley
Copy link
Member

If a SocketTimeoutException occurs when downloading a jar from a remote repo it seems that the partially transferred file is left of the filesystem. On a subsequent run things break because the zip file is invalid.

@tombentley
Copy link
Member Author

Maybe we should write to a foo-1.0.0.jar.part file and rename it when the download is complete. That would also allow us to resume a transfer using a range request.

@FroMage FroMage modified the milestone: 1.2 Sep 2, 2015
@FroMage FroMage self-assigned this Sep 2, 2015
@FroMage
Copy link
Member

FroMage commented Sep 2, 2015

Fixed. We'll implement partial files and resuming later, it's not a priority since most files are small, and I expect we'll need parallel downloads too later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants