-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md and update to latest WDK #23
Conversation
Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>
It's the latest available. Previous versions should still work. Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>
@Oxalin : Can you check cf76164 on dev branch ? It is a squashed commit from your 831a2b1. Disappointingly, $(LatestTargetPlatformVersion) is not working in userspace projects but kernel projects are OK. This seems to be a sort of VS bug. So fixed SDK version for userland projects should be specified. Anyway, it would be desirable that latest SDK & WDK are supported. I've confirmed that usbip-win is successfully built with old SDK(10.0.17134). I will merge to master if you confirm. |
As a follow up, I have not had a look at that commit yet.
I've been working on bringing a new feature available under Linux in the
little time I had in the last weeks: port enumeration. I'll keep you posted
about it soon... And I'll have a look at the commit. ;)
Alexandre
…On Mon, Mar 25, 2019, 03:57 KyungWoon Cho ***@***.***> wrote:
@Oxalin <https://github.com/Oxalin> : Can you check cf76164
<cf76164>
on dev branch ? It is a squashed commit from your 831a2b1
<831a2b1>.
Disappointingly, $(LatestTargetPlatformVersion) is not working in userspace
projects but kernel projects are OK. This seems to be a sort of VS bug. So
fixed SDK version for userland projects should be specified. Anyway, it
would be desirable that latest SDK & WDK are supported. I've confirmed that
usbip-win is successfully built with old SDK(10.0.17134). I will merge to
master if you confirm.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASgs7bRZ8AsjbEIDeLjQaxbwidzbPtPks5vaIF7gaJpZM4cFUuM>
.
|
@cezuni @Oxalin Userspace utilities are compiled by v142 (fc79b7b). V142 compiller needs SDK version >= 10.0.17*. I hope that WDK is written correctly and if they bring some breaking changes it does not break old WDK api. I suggest use "Lastest SDK and WDK" and add note with tested vesions (SDK >=10.0.17*). EDIT: It seems that WDK is supported and it's not problem import it by cmake - https://github.com/SergiusTheBest/FindWDK |
Waaw, the WDK has a static free version (called Enterprise WDK) I guest that rewrite project to CMake brings many advantages
|
I updated dev branch forcefully. This branch replaces fixed sdk versions with (LatestTargetPlatformVersion) in all userland projects. VS 2019 treats well $(LatestTargetPlatformVersion). |
@koudis : Your CMake idea is very good. However, is it possible that CMake is integrated with VS. Even though it is a command-only build tool, CMake can be a versatile additional build tool. In my opinion, CMake build process can be adopted independently of an existing VS build. |
@cezuni I will do some research... and see how difficult is to move/add project to CMake. |
This work has been merged into the master branch. I'll close this PR and remove dev branch. |
After #48 I try to create CMake project prototype for USBIP Project. |
Clarified and fixed README.md.
Updated Windows driver kit requirement to latest version (10.0.1763). Previous version should still work, but you will need to change the version in the VS projects.