vhci - multiple interfaces, "usbip install" feature #90

koudis · 2020-01-04T21:22:35Z

PR which repair some bug and improve support for composite interfaces. Support for usbip install feature

I had problems with usb devices which has many (>10) interfaces.

There were several problems in HUB implementation:

IoCancelIrp - bug in Dpc release lock
ABORT_PIPE request was not implemented correctly.
RESET_PIPE_AND_CLEAR_STALL was not implemented correctly against USBIP server hosted on linux machine. I guess that RESET_PIPE_AND_CLEAR_STALL works fine for USBIP server hosted on Windows machine.
CONTROL_TRANSFER_EX was NOT implement

Problems in usbip.exe userspace program:

I updated usbip_forward routine --> no deadlock, segfaults or BSOD is now possible (I tested it for vhci not for stub driver)
Change process priority to HIGH for attach command

I also merge StoyanDimitrov changes to my brach (due to small update in README.md).

After the PR test and approve I will merge all commits into one.

Improve readability

Further improvements

Point the user to *.cer file

Rename "Local Machine" as "Local Computer"

cezanne · 2020-01-31T15:21:39Z

@koudis : sorry for my long silence. I'll investigate your great work and try to merge.

cezanne · 2020-02-01T00:46:26Z

@koudis : koudis_install branch is created from your commits(02cef87 .. 45d3f1d). I slightly modified your commit to remove multiple blank lines and usbip_install_usage typo error. I know that the typo error was resolved by your recent commit.

Please check a merged commit ( cefbf94 )

Now, I would like to merge remaining your work related to a multiple interfaces issue.

NOTE: I have amended the old commit (55c8591) in order to apply your improvement for README.md, usbip.c and usbip_install.c.

koudis · 2020-02-01T12:04:51Z

Just warning: commits between f974e8e and the HEAD of my branch is not many useful :).

Just for sure - there are also some changes for Install feature which is not between 02cef87 .. 45d3f1d

But it seems that you already merged these commits into koudis_instal :).

I will test it tomorrow. (2. 2. or 3. 2.)

cezanne · 2020-02-01T20:37:29Z

@koudis : I've just closed by mistake and reopened.
I have tried to upload 2 commits from your works (one for usbip.exe and another for vhci driver).
Indeed, your commits are too~ long. 😄

Just warning: commits between f974e8e and the HEAD of my branch is not many useful :).

Just for sure - there are also some changes for Install feature which is not between 02cef87 .. 45d3f1d

16b75be

57384bd

3e36af7

2977697

But it seems that you already merged these commits into koudis_instal :).

I will test it tomorrow. (2. 2. or 3. 2.)

koudis · 2020-02-01T20:46:08Z

@cezuni I thought that we merge both features together. So I did not bother about "nice" commits.

If the problem with messy history occurred let me know and I will try it repair shortly :) .

driver/vhci/usb.ids

driver/vhci/usbip_vhci.vcxproj

koudis · 2020-02-03T13:56:05Z

@cezuni i test koudis_install branch and create #98 . There was smal bugfix due to missing deps for linker.

The inconsitent vhci lock_urbr release routine is fixed. Spin lock acquired by KeAcquireSpinLockAtDpcLevel() can be safely released by KeReleaseSpinLockFromDpcLevel(). This commit got hint from #90.

cezanne · 2020-02-07T05:13:49Z

@koudis : Please check 5530943 in master branch. KeReleaseSpinLock is replaced with KeReleaseSpinLockFromDpcLevel. In 7990030, you gave a hint. Thanks.
I think that KeReleaseSpinLockFromDpcLevel would be more desirable than KeReleaseSpinLockForDpc. Isn't it?

koudis · 2020-02-07T14:01:49Z

@cezuni Yes, I've read documentation once again and the doc explicitly says
"The caller should release the spin lock with KeReleaseSpinLockFromDpcLevel as quickly as possible."

Your commit looks more correct according to doc.

@koudis

This commit is derived from #90 by @koudis - Add debugging messages for URB FUNCTION codes - Add useful messages for vhci read/write routine

@koudis

This commit is inspired by @koudis(from #90) - complete pending IRP's and remove urbr's of an aborted pipe - resetting pipe is enhanced

cezanne · 2020-02-10T08:26:14Z

@koudis : I created abort_pipe branch and PR #101 in order to reviewing vhci_ioctl_abort_pipe and store_urb_reset_pipe. How about moving on #101?

koudis · 2020-02-11T09:52:35Z

@cezuni ok :).

Are you going to merge "URB_FUNCTION_CONTROL_TRANSFER_EX" into master?

If not I suggest to test master branch agains multiple inteface devices like Logitech Unyfing device. I had problem with interface initialization without this call (but for real I am not sure if TRANFER_EX it's really necessary).

koudis · 2020-02-11T10:06:18Z

Maybe we can consider to check URB_FUNCTION_CONTROL_TRANSFER too due to #102

cezanne · 2020-02-11T15:04:12Z

Are you going to merge "URB_FUNCTION_CONTROL_TRANSFER_EX" into master?

Yes, sure. But after #101.

If not I suggest to test master branch agains multiple inteface devices like Logitech Unyfing device. I had problem with interface initialization without this call (but for real I am not sure if TRANFER_EX it's really necessary).

I'll keep in mind. 😄

@koudis

This commit is inspired by @koudis(from #90) - complete pending IRP's and remove urbr's of an aborted pipe - resetting pipe is enhanced

@koudis

This commit is inspired and helped by @koudis(from #90) - complete pending IRP's and remove urbr's of an aborted pipe - correct a clearing pipe routine

StoyanDimitrov and others added 27 commits November 23, 2019 20:48

Update README.md

4924490

Improve readability

Update README.md

5b4631e

Further improvements

Update README.md

4eff712

Point the user to *.cer file

Update README.md

ecd8b6f

Rename "Local Machine" as "Local Computer"

Init

02cef87

Update

0672db7

Update

14537e8

Update

45d3f1d

Init

f974e8e

Init

0f2593e

Update

2591e23

Update

7b42be1

Update

b9ccbb4

Update

5208c0f

Update

3e23fa7

Update

03c0a3a

Update

23bb714

Update

372bbc0

Update

3267794

Update

2977697

Update

3e36af7

Update

57384bd

Update

95bda79

Update

53e6cda

Update

3080e8c

Merge remote-tracking branch 'Stoyan/patch-1' into jan_kubalek/works__

58f920f

Update

16b75be

koudis mentioned this pull request Jan 4, 2020

usbip driver install from command line #86

Closed

koudis changed the title ~~Jan kubalek/vhci interfaces~~ vhci - multiple interfaces, usbip install feature Jan 4, 2020

koudis mentioned this pull request Jan 4, 2020

problems with composite equipment ? #89

Closed

This was referenced Jan 31, 2020

Old usbip project does not work in the project #96

Closed

vhci driver installation problem #97

Closed

cezanne closed this Feb 1, 2020

cezanne reopened this Feb 1, 2020

cezanne reviewed Feb 1, 2020

View reviewed changes

driver/vhci/usb.ids Show resolved Hide resolved

driver/vhci/usbip_vhci.vcxproj Show resolved Hide resolved

koudis mentioned this pull request Feb 3, 2020

Bugfix in Release configuration #98

Closed

cezanne added a commit that referenced this pull request Feb 10, 2020

Add friendly debugging messages for vhci

4ebd9a9

This commit is derived from #90 by @koudis - Add debugging messages for URB FUNCTION codes - Add useful messages for vhci read/write routine

cezanne added a commit that referenced this pull request Feb 10, 2020

Remove pending urbr's of a vhci aborted pipe

a27f95f

This commit is inspired by @koudis(from #90) - complete pending IRP's and remove urbr's of an aborted pipe - resetting pipe is enhanced

cezanne mentioned this pull request Feb 10, 2020

Remove pending urbr's of a vhci aborted pipe #101

Closed

cezanne added a commit that referenced this pull request Feb 20, 2020

Remove pending urbr's of a vhci aborted pipe

d087ca5

This commit is inspired by @koudis(from #90) - complete pending IRP's and remove urbr's of an aborted pipe - resetting pipe is enhanced

cezanne added a commit that referenced this pull request Feb 22, 2020

Remove pending urbr's of a vhci aborted pipe

bcf3afa

This commit is inspired and helped by @koudis(from #90) - complete pending IRP's and remove urbr's of an aborted pipe - correct a clearing pipe routine

cezanne added a commit that referenced this pull request Feb 23, 2020

URB_FUNCTION_CONTROL_TRANSFER_EX from @koudis (#90)

1808d69

cezanne mentioned this pull request Feb 23, 2020

URB_FUNCTION_CONTROL_TRANSFER_EX #107

Closed

koudis closed this Mar 13, 2020

koudis deleted the jan_kubalek/vhci_interfaces branch March 13, 2020 21:25

koudis restored the jan_kubalek/vhci_interfaces branch March 14, 2020 13:42

koudis deleted the jan_kubalek/vhci_interfaces branch July 5, 2020 14:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vhci - multiple interfaces, "usbip install" feature #90

vhci - multiple interfaces, "usbip install" feature #90

koudis commented Jan 4, 2020 •

edited

Loading

cezanne commented Jan 31, 2020

cezanne commented Feb 1, 2020 •

edited

Loading

koudis commented Feb 1, 2020 •

edited

Loading

cezanne commented Feb 1, 2020

koudis commented Feb 1, 2020

koudis commented Feb 3, 2020 •

edited

Loading

cezanne commented Feb 7, 2020

koudis commented Feb 7, 2020 •

edited

Loading

cezanne commented Feb 10, 2020

koudis commented Feb 11, 2020

koudis commented Feb 11, 2020

cezanne commented Feb 11, 2020

vhci - multiple interfaces, "usbip install" feature #90

vhci - multiple interfaces, "usbip install" feature #90

Conversation

koudis commented Jan 4, 2020 • edited Loading

cezanne commented Jan 31, 2020

cezanne commented Feb 1, 2020 • edited Loading

koudis commented Feb 1, 2020 • edited Loading

cezanne commented Feb 1, 2020

koudis commented Feb 1, 2020

koudis commented Feb 3, 2020 • edited Loading

cezanne commented Feb 7, 2020

koudis commented Feb 7, 2020 • edited Loading

cezanne commented Feb 10, 2020

koudis commented Feb 11, 2020

koudis commented Feb 11, 2020

cezanne commented Feb 11, 2020

koudis commented Jan 4, 2020 •

edited

Loading

cezanne commented Feb 1, 2020 •

edited

Loading

koudis commented Feb 1, 2020 •

edited

Loading

koudis commented Feb 3, 2020 •

edited

Loading

koudis commented Feb 7, 2020 •

edited

Loading