Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published module now compiled JSX #3

Merged
merged 1 commit into from Apr 15, 2015
Merged

Published module now compiled JSX #3

merged 1 commit into from Apr 15, 2015

Conversation

cymen
Copy link
Contributor

@cymen cymen commented Apr 15, 2015

  • use 'jsx --harmony' to compile (run npm run build)
  • remove all of the unused files
  • sourcemaps and other concerns handled by consumer
  • remove example (I suggest making a react-progress-example, put a webpack config in there and have it pull in this module and use it -- then point README to there)

* use 'jsx --harmony' to compile (run `npm run build`)
* remove all of the unused files
* sourcemaps and other concerns handled by consumer
@cymen
Copy link
Contributor Author

cymen commented Apr 15, 2015

@cezary This is similar to the other PR except lib/react-progress.js is untouched -- the Harmony string interpolation remains along with JSX. I can make the example if you want but I think it would be much cleaner to do that in a separate repo.

cezary added a commit that referenced this pull request Apr 15, 2015
Published module now compiled JSX
@cezary cezary merged commit ff0c6e2 into cezary:master Apr 15, 2015
@cezary
Copy link
Owner

cezary commented Apr 15, 2015

Nice! Much simpler project layout, thanks! I think I'll keep the demo in the gh-pages branch.

@cezary cezary mentioned this pull request Apr 15, 2015
@cymen
Copy link
Contributor Author

cymen commented Apr 15, 2015

@cezary Thanks for merging! I bumped the version to 0.0.3 so if you get the time to do an npm publish, that would be awesome (I'm using this in a project). Thanks for the module.

@cezary
Copy link
Owner

cezary commented Apr 15, 2015

You're welcome, published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants