Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Studio - toolset update #41

Closed
wants to merge 1 commit into from
Closed

Visual Studio - toolset update #41

wants to merge 1 commit into from

Conversation

koudis
Copy link
Collaborator

@koudis koudis commented Jun 23, 2019 •
edited
Loading

PR for Toolset update.

  • added WDK 10 - 1903 and SDK 10.0.18362 as default,
  • changed default digest alg (on Win 10 sha1 is not trusted and can lead to unexpected behaviour)

New MSVC compiller and newest WDK 10 can improve performance and stability.

If the PR will be approved I wil lsquash all commits into one.

@koudis
Copy link
Collaborator Author

koudis commented Jun 23, 2019 •
edited
Loading

Client

I test Win client <--> Linux Server

  • server was on Debian Stretch (Linux v4.9)
  • server was on Ubuntu Bionic (Linux v4.15)

Everything works fine (even with patch from #20 ).

Server

Does not work. If I start client on Debian Stretch and try to connect to my Windows 10 Home, it fails with
"Cannot read config"
But it's not a PR problem. The same problem occured if I build master, delete stub driver and device, install the new once from master...

@koudis koudis changed the title Jan kubalek/vs toolset update Visual Studio - toolset update Jun 23, 2019
@cezuni
Copy link

cezuni commented Jun 24, 2019

For your suggestion, I need to upgrade my environment. I'll do in a few days. Can you create another PR in single squashed commit to master branch?

@koudis
Copy link
Collaborator Author

koudis commented Jun 24, 2019

ok, I will do it later this week.

@cezuni cezuni mentioned this pull request Jun 25, 2019
Closed
@cezuni
Copy link

cezuni commented Jun 25, 2019

I have updated toolset with no ATL/MFC support because ATL/MFC is too big package. BTW, build reports "warning MSB8038: Spectre mitigation is enabled but Spectre mitigated libraries are not found" (Please refer MSDN). So how about disabling /Qspectre option when you create a squashed commit?

@koudis koudis force-pushed the jan_kubalek/vs_toolset_update branch from 7bdef65 to 664b032 Compare June 27, 2019 10:18
@koudis
Copy link
Collaborator Author

koudis commented Jun 27, 2019

@cezuni
I disable Spectre Mitigation and squash all commits into one.

I test code on new virtual without MFC, ATL, ... and it seems to work. But for sure - can you try to compile branch with your environment?

@cezuni
Copy link

cezuni commented Jul 1, 2019

I had rebased @koudis 's 664b032 and checked that vhci is working correctly. As a result, fc79b7b is merged on master. As @koudis pointed out, a stub driver is not working. This problem seems to be related to packet forwarding stuff not to this issue.

@koudis
Copy link
Collaborator Author

koudis commented Jul 1, 2019

@cezuni Thank You. Can we close to PR?

@cezuni
Copy link

cezuni commented Jul 2, 2019

Can we close to PR?

Yes, you can. But can you look at a similar issue?
#23 is related to this PR, where I had tried to introduce a generic project file. VS2019 seems good to work.

@koudis koudis closed this Jul 3, 2019
@cezuni cezuni mentioned this pull request Jul 5, 2019
Closed
@koudis koudis deleted the jan_kubalek/vs_toolset_update branch July 8, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@koudis @cezuni