Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udunits items #385

Closed
erget opened this issue Sep 12, 2022 · 6 comments · Fixed by #390
Closed

udunits items #385

erget opened this issue Sep 12, 2022 · 6 comments · Fixed by #390
Assignees
@davidhassell @larsbarring
Labels
defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors

Comments

@erget
Copy link
Member

erget commented Sep 12, 2022

From Lars Bärring:

UDUNITS is mentioned as one theme for the housekeeping session. I have
done a bit of preliminary work in relation to this, just to identify
where UDUNITS is referenced in a more specific way than just linking to
the homepage over at UNIDATA. For many (maybe all) of those places I
have for myself some questions and thoughts.

As I am a git/asciidoc anti-guru I have just extracted those pieces
into a document and added my thoughts as comments into a pdf file
(attached), which maybe could serve as a starting point for some
further work, or just folded into an electronic paper plane and thrown
out the Windows.
@erget
Copy link
Member Author

erget commented Sep 12, 2022

CF Conventions text -- annotated UDUNITS refs.pdf

@davidhassell
Copy link
Contributor

In #298 (comment), Steve Emmerson says: Unidata documentation seems to favour "UDUNITS"

@davidhassell davidhassell self-assigned this Sep 13, 2022
@larsbarring larsbarring self-assigned this Sep 13, 2022
@davidhassell davidhassell mentioned this issue Sep 13, 2022
Merged
4 tasks
@erget erget linked a pull request Sep 13, 2022 that will close this issue
UDUNITS clarifications from workshop housekeeping 2022 #390
Merged
4 tasks
@erget erget reopened this Sep 15, 2022
@erget
Copy link
Member Author

erget commented Sep 15, 2022

This is done, but still needs to be merged after the 3w deadline has passed - apologies for being too trigger happy, I was trying to clean things up so that we have as clean a slate as possible for finishing the week. See the corresponding PR - I will rebase those commits onto the Conventions in 3 weeks pending objections.

@larsbarring
Copy link
Contributor

The associated PR will also take care of #260, which consequently can be closed together with this one.

@JonathanGregory
Copy link
Contributor

These changes look fine to me, thanks.

@JonathanGregory JonathanGregory added style defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors labels Sep 16, 2022
@erget
Copy link
Member Author

erget commented Oct 6, 2022

Merged via cherry-pick, see unnecessarily complicated #390

@erget erget closed this as completed Oct 6, 2022
@erget erget mentioned this issue Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidhassell davidhassell

@larsbarring larsbarring

Labels
defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors
Projects
No open projects
Housekeeping at 2022 workshop
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UDUNITS clarifications from workshop housekeeping 2022 davidhassell/cf-conventions
4 participants
@erget @JonathanGregory @davidhassell @larsbarring