Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MySQL #14

Closed
pacphi opened this issue Mar 22, 2019 · 2 comments
Closed

Add support for MySQL #14

pacphi opened this issue Mar 22, 2019 · 2 comments
Labels
feature New feature or request

Comments

@pacphi
Copy link
Collaborator

pacphi commented Mar 22, 2019 •
edited

See https://spring.io/blog/2019/03/20/spring-tips-reactive-mysql-support-with-jasync-sql-and-r2dbc.

Should just mean...

  • adding schema.ddl specific for mysql
  • adding a dependency in build.gradle
  • enhancing the IndexPrefix enum
  • updating samples and readme steps to target and bind to an external mysql instance on Cloud Foundry
@pacphi pacphi added the feature New feature or request label Mar 22, 2019
@pacphi pacphi added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jun 29, 2019
@pacphi
Copy link
Collaborator Author

pacphi commented Jul 5, 2019

There's an alternative implementation to consider here but it doesn't currently support SSL, https://github.com/mirromutth/r2dbc-mysql.

@pacphi pacphi changed the title Add support for jasync-r2dbc-mysql Add support for MySQL Jul 5, 2019
pacphi added a commit that referenced this issue Jul 8, 2019
@pacphi
Begin to support MySQL
db5225a 
* Start to address issue #14
* Favoring use of https://github.com/mirromutth/r2dbc-mysql
* Add convenience script for fetch and build of source since release of aforementioned provider is not yet available publicly
* Move DatabaseCreator and PoliciesLoader to task package
* Move GitClient to client package
* Update deprecated R2DBC API calls (e.g., execute().sql(... becomes execute(... )
* Add schema.ddl for MySQL
* Plumb additional choice in DbmsSettings#IndexPrefix
* Update README with instructions on how to get going w/ MySQL
* Finally add a variant build.w-mysql.gradle that adds mavenLocal() managed repository

> Still having issues at startup; will resolve in subsequent commit(s)
@pacphi
Copy link
Collaborator Author

pacphi commented Jul 9, 2019

Tracking with this PR.

@pacphi pacphi closed this as completed Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pacphi