Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HCV scoring rules #436

Closed
20 tasks done
donkirkby opened this issue Feb 26, 2018 · 3 comments
Closed
20 tasks done

Update HCV scoring rules #436

donkirkby opened this issue Feb 26, 2018 · 3 comments
Assignees

Comments

@donkirkby
Copy link
Member

donkirkby commented Feb 26, 2018

Anita is working on a new set of rules in a big spreadsheet.

  • parse 'resistance likely' and 'resistance possible' rules from the spreadsheet
  • avoid splitting within score terms
  • add reference sequence names
  • parse 'effect unknown' rules
  • parse mutation combinations Split to issue Score HCV mutation combinations #440.
  • get codes and full names for new drugs
  • Allow clinical observations without fold shifts
  • Support < or </= in fold-shift data
  • overrides for GT2a/2b and GT4a/4d
  • wait for NS5b rules in regular tab format
  • don't check wild type when subtype is overridden (Postponed until subtypes are validated in Validate HCV subtype calls #443.)
  • always report subtype at top of report (Postponed until subtypes are validated.)
  • when subtype is not "a", include note on report: "resistance inferred from subtype Xa" (Postponed until subtypes are validated.)
  • special case to display note when a mutation only has data from 2b or 4d (Postponed until subtypes are validated.)
  • special case for Sofosbuvir in genotype 6? different rules for Harvoni and Epclusa? should the 6e special case be on the other Sofosbuvir?
  • special case for Sofosbuvir: all mutations at position 282 are resistance likely (don't check fold shift)
  • combine GT2 back into single tab and same for GT4
  • mark mutations with an asterisk when the variant matches the wild type, because it's from a different subtype (Postponed until subtypes are validated.)
  • remove Boceprevir and Telaprevir from the reports, because they're obsolete
  • look for multiple mutations with the same variant in the same genotype, but different scores
@jeff-k
Copy link
Contributor

jeff-k commented Mar 9, 2018

For parsing the spreadsheet we want to check if there are any other combination/individual variants that are a proper subset of the variants in another combination. If a subset of a combination's variants score higher than that combination, then that subset will also be called and the mitigating component will not be considered.

So, if (Q80K AND V168Y) => 8 but (Q80K AND V168Y AND L82P) => 4, where L82P is the mitigating variant, we need to make sure we take the minimum of these two scores and evaluate them only once.

When we process the spreadsheet we should check if any other rules are entailed by the one we're considering and construct a MIN ( ... ) expression with them both.

Attached is a comma separated list of rules that satisfies the expected scores in the spreadsheet.
hcv_rules.txt

@jeff-k
Copy link
Contributor

jeff-k commented Mar 10, 2018

Here's the rules with disjoint MAX combinations split up like MINS are and some more redundant rules eliminated:
hcv_rules_split_max.txt

@donkirkby
Copy link
Member Author

donkirkby commented May 15, 2018

I linked commits a7bff81, cbdb221, 8ab315d, 0165d12, 8a00ac9, and 23538e4 to issue #440 when I should have linked them to this issue.

donkirkby added a commit that referenced this issue May 23, 2018
Display "Not indicated" in rules.
donkirkby added a commit that referenced this issue Jun 6, 2018
Also add more rules for checking fold-shift range boundaries.
donkirkby added a commit that referenced this issue Jun 12, 2018
Also add [Conflicting WT] flag to ignore wild type mismatches.
donkirkby added a commit that referenced this issue Jun 13, 2018
donkirkby added a commit that referenced this issue Jun 15, 2018
Their resistance rules were removed as part of #436.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants