Set the exit value when running cf-key #2903
Conversation
|
I like this. But I'm not sure about the change in behaviour: cf-key becomes silent by default, printing nothing on the console. @nickanderson what do you think? The commit message needs a big "changelog" tag btw. |
|
I don't see any issue with suppressing "Making a key pair for CFEngine, please wait, this could take a minute..." by default with cf-key. +1 for exit code. Not for currently released branches. |
|
@skreuzer can you ammend your commit to include the line: |
I just amended the commit message with that line |
When running cf-key to generate new keys, set the exit value of the program to be 0 on success and 1 on failure. This makes it easier to catch errors during setup of a new machine. Change the default behavior of the program to not write anything to stdout, opting to use the Log() function which can write to stdout and will also allow output to be sent to syslog. Add a --inform option to set the global log level to LOG_LEVEL_INFO. Change the permissions of the randseed file to 600 and catch the exception if the chmod call fails. Changelog: commit
|
Merged, thanks! I still think that LOG_LEVEL_NOTICE would be better for that single message "generating keys", because it might hang for a while. Anyway merged, we can always tweak it later. |
When running cf-key to generate new keys, set the exit value of the
program to be 0 on success and 1 on failure. This makes it easier to
catch errors during setup of a new machine.
Change the default behavior of the program to not write anything to stdout,
opting to use the Log() function which can write to stdout and will also
allow output to be sent to syslog.
Add a --inform option to set the global log level to LOG_LEVEL_INFO.
Change the permissions of the randseed file to 600 and catch the exception
if the chmod call fails.