CFE-4315: Modified packages promise default to use module if present #5434
Conversation
|
Thanks for submitting a PR! Maybe @larsewi can review this? |
craigcomstock
force-pushed
the
CFE-4315/master
branch
from
37404e5
to
32a2830
Compare
|
@cf-bottom jenkins please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10360/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10360/ |
|
@cf-bottom jenkins no tests |
|
Alright, I triggered a build: [NO TESTS] Jenkins: https://ci.cfengine.com/job/pr-pipeline/10364/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10364/ |
|
@cf-bottom jenkins |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10369/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10369/ |
|
@cf-bottom jenkins please, thanks |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10381/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10381/ |
|
@cf-bottom jenkins no tests please, thanks |
|
Alright, I triggered a build: [NO TESTS] Jenkins: https://ci.cfengine.com/job/pr-pipeline/10435/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10435/ |
|
@cf-bottom jenkins no tests |
|
Alright, I triggered a build: [NO TESTS] Jenkins: https://ci.cfengine.com/job/pr-pipeline/10448/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10448/ |
craigcomstock
force-pushed
the
CFE-4315/master
branch
from
32a2830
to
7e070b6
Compare
|
@cf-bottom jenkins with exotics |
|
Alright, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/10495/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10495/ |
There was a problem hiding this comment.
Seems OK.
In the end, this only changes behavior for a very specific case:
With this change the following policy would use the default package_module instead of the default package_method if it could.
packages:
"ed";
Any case where more info is supplied to the promise (like use of package_method, or package_policy) would cause the package_method implementation to be used.
craigcomstock
force-pushed
the
CFE-4315/master
branch
from
c63d601
to
f297b3d
Compare
…that package module. Previously if a policy that only specified the promiser: packages: "ed"; It will default to package_method generic in our C code. Now it will look for package_module_knowledge.platform_default and if present make the package promise use package module instead. Ticket: CFE-4315 Changelog: title Co-authored-by: Lars Erik Wik <53906608+larsewi@users.noreply.github.com>
craigcomstock
force-pushed
the
CFE-4315/master
branch
from
7738581
to
f23e268
Compare
|
I was going to work on changing documentation to match the switch from old->v1 and new->v2 but found the change to be quite difficult due to auto-linking between page names/headers and such. So will go ahead and merge and cherry pick this change as-is and make a ticket to fix the names in docs. |
merge with cfengine/documentation#3237