Comments, and also remove #+fsbv usage in the tests.

cffi · Jan 28, 2016 · b15c7ce · b15c7ce
1 parent a99453f
commit b15c7ce
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/libffi/funcall.lisp b/libffi/funcall.lisp
@@ -120,4 +120,9 @@
 
 (setf *foreign-structures-by-value* 'foreign-funcall-form/fsbv-with-libffi)
 
+;; DEPRECATED Its presence encourages the use of #+fsbv which may lead to the
+;; situation where a fasl was produced by an image that has fsbv feature
+;; and then ends up being loaded into an image later that has no fsbv support
+;; loaded. Use explicit ASDF dependencies instead and assume the presence
+;; of the feature accordingly.
 (pushnew :fsbv *features*)
diff --git a/src/features.lisp b/src/features.lisp
@@ -1,6 +1,6 @@
 ;;;; -*- Mode: lisp; indent-tabs-mode: nil -*-
 ;;;
-;;; features.lisp --- CFFI-specific features.
+;;; features.lisp --- CFFI-specific features (DEPRECATED).
 ;;;
 ;;; Copyright (C) 2006-2007, Luis Oliveira  <loliveira@common-lisp.net>
 ;;;

diff --git a/tests/bindings.lisp b/tests/bindings.lisp
@@ -101,7 +101,7 @@
   (let ((*foreign-library-directories* (list (load-directory))))
     (load-foreign-library 'libtest)
     (load-foreign-library 'libtest2)
-    #+fsbv (load-foreign-library 'libfsbv)
+    (load-foreign-library 'libfsbv)
     (load-foreign-library 'libc)
     #+(or abcl lispworks) (load-foreign-library 'libm)))